Standardize log constant naming and declaration placement

This commit is contained in:
Kristóf Tóth
2018-03-25 16:06:59 +02:00
parent 1e2ea0ed17
commit aacdbcb0d1
9 changed files with 38 additions and 29 deletions

View File

@ -7,7 +7,8 @@ from tfw.networking.event_handlers.server_connector import ServerUplinkConnector
from tfw.components.decorators import RateLimiter
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class DirectoryMonitor:
@ -64,7 +65,7 @@ class WebideReloadWatchdogEventHandler(FileSystemWatchdogEventHandler):
if self.ignore > 0:
self.ignore = self.ignore - 1
return
log.debug(event)
LOG.debug(event)
key = 'webide'
self.uplink.send(key, {'data': {'command': 'reload'}})

View File

@ -3,7 +3,8 @@ from os.path import isdir, exists
from tfw.components.directory_monitor import DirectoryMonitor
from tfw.event_handler_base import TriggerlessEventHandler
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class DirectoryMonitoringEventHandler(TriggerlessEventHandler):
@ -42,7 +43,7 @@ class DirectoryMonitoringEventHandler(TriggerlessEventHandler):
message['data'] = self.commands[message['data']['command']](message['data'])
return message
except KeyError:
log.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
def pause(self, data):
self.monitor.pause()
@ -62,7 +63,7 @@ class DirectoryMonitoringEventHandler(TriggerlessEventHandler):
self.reload_monitor()
return data
except EnvironmentError:
log.error('Failed to switch directory!')
LOG.error('Failed to switch directory!')
def cleanup(self):
self.monitor.stop()

View File

@ -4,7 +4,8 @@ from tfw.event_handler_base import TriggerlessEventHandler
from tfw.components.mixins import SupervisorMixin
from tfw.components.directory_monitor import with_monitor_paused
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class ProcessManager(SupervisorMixin):
@ -32,7 +33,7 @@ class ProcessManagingEventHandler(TriggerlessEventHandler):
self.processmanager(data['command'], data['process_name'])
return message
except KeyError:
log.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
except SupervisorFault as fault:
message['data']['error'] = fault.faultString
message['data']['log'] = self.processmanager.read_log(message['data']['process_name'])

View File

@ -6,7 +6,8 @@ from collections import Iterable
from tfw.event_handler_base import TriggerlessEventHandler
from tfw.components.directory_monitor import DirectoryMonitor
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class FileManager:
@ -103,13 +104,13 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
def write(self, data):
self.monitor.ignore = self.monitor.ignore + 1
try: self.filemanager.file_contents = data['content']
except Exception: log.exception('Error writing file!')
except Exception: LOG.exception('Error writing file!')
del data['content']
return data
def select(self, data):
try: self.filemanager.filename = data['filename']
except EnvironmentError: log.exception('Failed to select file "{}"'.format(data['filename']))
except EnvironmentError: LOG.exception('Failed to select file "{}"'.format(data['filename']))
return data
def select_dir(self, data):
@ -122,12 +123,12 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
except IndexError:
data['content'] = 'No files in this directory :('
except EnvironmentError:
log.error('Failed to select directory "{}"'.format(data['directory']))
LOG.error('Failed to select directory "{}"'.format(data['directory']))
return data
def exclude(self, data):
try: self.filemanager.exclude = list(data['exclude'])
except TypeError: log.error('Exclude must be Iterable!')
except TypeError: LOG.error('Exclude must be Iterable!')
return data
def attach_fileinfo(self, data):
@ -142,7 +143,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
self.attach_fileinfo(data)
return message
except KeyError:
log.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
def cleanup(self):
self.monitor.stop()

View File

@ -3,7 +3,8 @@ from tfw.components.history_monitor import HistoryMonitor
from tfw.event_handler_base import TriggerlessEventHandler
from tfw.config import tfwenv
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class TerminadoEventHandler(TriggerlessEventHandler):
@ -22,12 +23,12 @@ class TerminadoEventHandler(TriggerlessEventHandler):
return self._historymonitor
def handle_event(self, key, message):
log.debug('TerminadoEventHandler received event: {}'.format(message))
LOG.debug('TerminadoEventHandler received event: {}'.format(message))
try:
message['data'] = self.commands[message['data']['command']](message['data'])
return message
except KeyError:
log.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
def write(self, data):
self.terminado_server.pty.write(data['shellcmd'])

View File

@ -4,7 +4,8 @@ from terminado import TermSocket, SingleTermManager
from tfw.config import tfwenv
from tfw.config.logs import logging
log = logging.getLogger(__name__)
LOG = logging.getLogger(__name__)
class TerminadoMiniServer:
@ -41,6 +42,6 @@ class TerminadoMiniServer:
if __name__ == '__main__':
log.info('Terminado Mini Server listening on {}'.format(tfwenv.TERMINADO_PORT))
LOG.info('Terminado Mini Server listening on {}'.format(tfwenv.TERMINADO_PORT))
TerminadoMiniServer('/terminal', tfwenv.TERMINADO_PORT, tfwenv.TERMINADO_WD, ['bash']).listen()
IOLoop.instance().start()