mrtoth/baseimage-tutorial-framework
1
0
Fork 0
mirror of https://github.com/avatao-content/baseimage-tutorial-framework synced 2025-06-28 21:45:11 +00:00
Code Issues Releases Wiki Activity

Make use of format string optimization in logging calls

Browse Source
This commit is contained in:
Kristóf Tóth
2018-03-25 16:25:01 +02:00
parent 73ed680298
commit 8eded8cbac
8 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/tfw/components/directory_monitoring_event_handler.py
View File

@ -43,7 +43,7 @@ class DirectoryMonitoringEventHandler(TriggerlessEventHandler):
message['data'] = self.commands[message['data']['command']](message['data'])
return message
except KeyError:
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: %s', message)
def pause(self, data):
self.monitor.pause()

2
lib/tfw/components/process_managing_event_handler.py
View File

@ -33,7 +33,7 @@ class ProcessManagingEventHandler(TriggerlessEventHandler):
self.processmanager(data['command'], data['process_name'])
return message
except KeyError:
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: %s', message)
except SupervisorFault as fault:
message['data']['error'] = fault.faultString
message['data']['log'] = self.processmanager.read_log(message['data']['process_name'])

6
lib/tfw/components/source_code_event_handler.py
View File

@ -110,7 +110,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
def select(self, data):
try: self.filemanager.filename = data['filename']
except EnvironmentError: LOG.exception('Failed to select file "{}"'.format(data['filename']))
except EnvironmentError: LOG.exception('Failed to select file "%s"', data['filename'])
return data
def select_dir(self, data):
@ -123,7 +123,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
except IndexError:
data['content'] = 'No files in this directory :('
except EnvironmentError:
LOG.error('Failed to select directory "{}"'.format(data['directory']))
LOG.error('Failed to select directory "%s"', data['directory'])
return data
def exclude(self, data):
@ -143,7 +143,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler):
self.attach_fileinfo(data)
return message
except KeyError:
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: %s', message)
def cleanup(self):
self.monitor.stop()

4
lib/tfw/components/terminado_event_handler.py
View File

@ -23,12 +23,12 @@ class TerminadoEventHandler(TriggerlessEventHandler):
return self._historymonitor
def handle_event(self, key, message):
LOG.debug('TerminadoEventHandler received event: {}'.format(message))
LOG.debug('TerminadoEventHandler received event: %s', message)
try:
message['data'] = self.commands[message['data']['command']](message['data'])
return message
except KeyError:
LOG.error('IGNORING MESSAGE: Invalid message received: {}'.format(message))
LOG.error('IGNORING MESSAGE: Invalid message received: %s', message)
def write(self, data):
self.terminado_server.pty.write(data['shellcmd'])

2
lib/tfw/components/terminado_mini_server.py
View File

@ -42,6 +42,6 @@ class TerminadoMiniServer:
if __name__ == '__main__':
LOG.info('Terminado Mini Server listening on {}'.format(tfwenv.TERMINADO_PORT))
LOG.info('Terminado Mini Server listening on %s', tfwenv.TERMINADO_PORT)
TerminadoMiniServer('/terminal', tfwenv.TERMINADO_PORT, tfwenv.TERMINADO_WD, ['bash']).listen()
IOLoop.instance().start()