mrtoth/frontend-tutorial-framework
1
0
Fork 0
mirror of https://github.com/avatao-content/frontend-tutorial-framework synced 2025-10-31 02:32:55 +00:00
Code Issues Releases Wiki Activity

Refactor ProcessManagerService error and success callback semantics

Browse Source
This commit is contained in:
Kristóf Tóth
2018-05-18 10:28:14 +02:00
parent 5ebe29ccc8
commit 4b79d77fcc
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/app/ide/ide.component.ts
View File

@@ -74,11 +74,9 @@ export class IdeComponent implements OnInit {
initProcessManagerService() { initProcessManagerService() {
this.processManagerService.init(); this.processManagerService.init();
this.processManagerService.subscribeCallback(config.ide.deployProcessName, (event) => { this.processManagerService.subscribeCallback(config.ide.deployProcessName, (event) => this.deploymentNotificationService.deploying.next(false));
this.setDeployButtonState('DEPLOYED'); this.processManagerService.subscribeSuccessCallback(config.ide.deployProcessName, (event) => this.setDeployButtonState('DEPLOYED'));
this.deploymentNotificationService.deploying.next(false); this.processManagerService.subscribeErrorCallback(config.ide.deployProcessName, (event) => this.setDeployButtonState('FAILED'));
});
this.processManagerService.subscribeErrorCallback(config.ide.deployProcessName, (event) => { this.setDeployButtonState('FAILED'); });
} }
updateFileData(data: SourceCode) { updateFileData(data: SourceCode) {

4
src/app/services/processmanager.service.ts
View File

@@ -24,6 +24,10 @@ export class ProcessManagerService {
this.observeProcessMessage(process_name).subscribe(callback); this.observeProcessMessage(process_name).subscribe(callback);
} }
subscribeSuccessCallback(process_name: string, callback: (event: WSMessage<ProcessCommand>) => void) {
this.observeProcessMessage(process_name).pipe(filter(message => !('error' in message.data))).subscribe(callback);
}
subscribeErrorCallback(process_name: string, callback: (event: WSMessage<ProcessCommand>) => void) { subscribeErrorCallback(process_name: string, callback: (event: WSMessage<ProcessCommand>) => void) {
this.observeProcessMessage(process_name).pipe(filter(message => 'error' in message.data)).subscribe(callback); this.observeProcessMessage(process_name).pipe(filter(message => 'error' in message.data)).subscribe(callback);
} }