From d850f55b86c0cfeec03dddc7c36077f2cc901074 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20T=C3=B3th?= Date: Fri, 30 Mar 2018 18:11:38 +0200 Subject: [PATCH] Add pylint local excludes to silence false positives --- lib/tao/config/__init__.py | 2 +- lib/tfw/components/history_monitor.py | 1 + lib/tfw/components/source_code_event_handler.py | 4 ++-- lib/tfw/components/terminado_mini_server.py | 2 +- lib/tfw/event_handler_base.py | 5 +++++ lib/tfw/fsm_base.py | 2 +- lib/tfw/networking/server/controller_responder.py | 2 ++ lib/tfw/networking/server/tfw_server.py | 2 ++ lib/tfw/networking/server/zmq_websocket_handler.py | 2 ++ 9 files changed, 17 insertions(+), 5 deletions(-) diff --git a/lib/tao/config/__init__.py b/lib/tao/config/__init__.py index d3319d7..08aca1a 100644 --- a/lib/tao/config/__init__.py +++ b/lib/tao/config/__init__.py @@ -1 +1 @@ -from .envvars import * +from .envvars import * # pylint: disable=wildcard-import diff --git a/lib/tfw/components/history_monitor.py b/lib/tfw/components/history_monitor.py index 1fb6c77..0d9279f 100644 --- a/lib/tfw/components/history_monitor.py +++ b/lib/tfw/components/history_monitor.py @@ -50,6 +50,7 @@ class HistoryMonitor(CallbackMixin, ABC): raise NotImplementedError def sanitize_command(self, command): + # pylint: disable=no-self-use return command def _invoke_callbacks(self): diff --git a/lib/tfw/components/source_code_event_handler.py b/lib/tfw/components/source_code_event_handler.py index 3e58a62..3f9caf5 100644 --- a/lib/tfw/components/source_code_event_handler.py +++ b/lib/tfw/components/source_code_event_handler.py @@ -105,7 +105,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler): data['content'] = 'You have no permission to open that file :(' except FileNotFoundError: data['content'] = 'This file was removed :(' - except Exception: + except Exception: # pylint: disable=broad-except data['content'] = 'Failed to read file :(' return data @@ -113,7 +113,7 @@ class SourceCodeEventHandler(TriggerlessEventHandler): self.monitor.ignore = self.monitor.ignore + 1 try: self.filemanager.file_contents = data['content'] - except Exception: + except Exception: # pylint: disable=broad-except LOG.exception('Error writing file!') del data['content'] return data diff --git a/lib/tfw/components/terminado_mini_server.py b/lib/tfw/components/terminado_mini_server.py index 613e749..e796e8c 100644 --- a/lib/tfw/components/terminado_mini_server.py +++ b/lib/tfw/components/terminado_mini_server.py @@ -29,7 +29,7 @@ class TerminadoMiniServer: def pty(self): return self.term_manager.terminal.ptyproc - class ResetterTermSocket(TermSocket): + class ResetterTermSocket(TermSocket): # pylint: disable=abstract-method def check_origin(self, origin): return True diff --git a/lib/tfw/event_handler_base.py b/lib/tfw/event_handler_base.py index 562ac07..e60d698 100644 --- a/lib/tfw/event_handler_base.py +++ b/lib/tfw/event_handler_base.py @@ -25,6 +25,7 @@ class EventHandlerBase(ABC): raise NotImplementedError def _dispatch_handling(self, key, message): + # pylint: disable=no-else-return if key != 'reset': return self.handle_event(key, message) else: @@ -35,6 +36,7 @@ class EventHandlerBase(ABC): raise NotImplementedError def handle_reset(self, message): + # pylint: disable=unused-argument,no-self-use return None def cleanup(self): @@ -66,11 +68,13 @@ class EventHandlerBase(ABC): class TriggerlessEventHandler(EventHandlerBase, ABC): + # pylint: disable=abstract-method def dispatch_handling(self, key, message): return self._dispatch_handling(key, message) class TriggeredEventHandler(EventHandlerBase, ABC): + # pylint: disable=abstract-method def __init__(self, key, trigger): super().__init__(key) self.trigger = trigger @@ -78,3 +82,4 @@ class TriggeredEventHandler(EventHandlerBase, ABC): def dispatch_handling(self, key, message): if message.get('trigger') == self.trigger: return self._dispatch_handling(key, message) + return None diff --git a/lib/tfw/fsm_base.py b/lib/tfw/fsm_base.py index 4160512..9927215 100644 --- a/lib/tfw/fsm_base.py +++ b/lib/tfw/fsm_base.py @@ -23,4 +23,4 @@ class FSMBase(CallbackMixin): self._execute_callbacks(event_data.kwargs) def is_solved(self): - return self.state in self.accepted_states + return self.state in self.accepted_states # pylint: disable=no-member diff --git a/lib/tfw/networking/server/controller_responder.py b/lib/tfw/networking/server/controller_responder.py index a0924e7..d85e31a 100644 --- a/lib/tfw/networking/server/controller_responder.py +++ b/lib/tfw/networking/server/controller_responder.py @@ -20,6 +20,7 @@ class ControllerResponder: stream.send_multipart(serialize_all(self.token, response)) def handle_test_request(self, data): + # pylint: disable=unused-argument,no-self-use return 'OK' def handle_token_request(self, data): @@ -28,6 +29,7 @@ class ControllerResponder: return {'token': self.token} def handle_solution_check_request(self, data): + # pylint: disable=unused-argument return { 'solved': self.fsm.is_solved(), 'message': 'solved' if self.fsm.is_solved() else 'not solved' diff --git a/lib/tfw/networking/server/tfw_server.py b/lib/tfw/networking/server/tfw_server.py index 0b9f593..a5f9aa6 100644 --- a/lib/tfw/networking/server/tfw_server.py +++ b/lib/tfw/networking/server/tfw_server.py @@ -40,6 +40,7 @@ class TFWServer: return message def proxy_filter(self, message): + # pylint: disable=unused-argument,no-self-use return True def listen(self, port): @@ -83,6 +84,7 @@ class FSMUpdater: self.uplink = ServerUplinkConnector() def update(self, kwargs_dict): + # pylint: disable=unused-argument self.uplink.send(*self.generate_fsm_update()) def generate_fsm_update(self): diff --git a/lib/tfw/networking/server/zmq_websocket_handler.py b/lib/tfw/networking/server/zmq_websocket_handler.py index 08fbadb..452c516 100644 --- a/lib/tfw/networking/server/zmq_websocket_handler.py +++ b/lib/tfw/networking/server/zmq_websocket_handler.py @@ -61,7 +61,9 @@ class ZMQWebSocketHandler(WebSocketHandler, ABC): class ZMQWebSocketProxy(ZMQWebSocketHandler): + # pylint: disable=abstract-method def initialize(self, make_response, proxy_filter): + # pylint: disable=arguments-differ self._make_response = make_response self._proxy_filter = proxy_filter