From 3fad818b2b61b214eab27aad3fd2907561cb9118 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20T=C3=B3th?= Date: Thu, 26 Jul 2018 16:29:20 +0200 Subject: [PATCH] Add pylint pre-push hooks --- .git-hooks/apply_hooks.sh | 22 ++++++++++++++++++++++ .git-hooks/pre-push.sh | 18 ++++++++++++++++++ .pylintrc | 6 ++++++ 3 files changed, 46 insertions(+) create mode 100755 .git-hooks/apply_hooks.sh create mode 100755 .git-hooks/pre-push.sh diff --git a/.git-hooks/apply_hooks.sh b/.git-hooks/apply_hooks.sh new file mode 100755 index 0000000..f95f8f4 --- /dev/null +++ b/.git-hooks/apply_hooks.sh @@ -0,0 +1,22 @@ +#!/usr/bin/env bash +set -eu +set -o pipefail +set -o errtrace +shopt -s expand_aliases + +[ "$(uname)" == "Darwin" ] && alias readlink="greadlink" || : + +GREEN='\033[0;32m' +NC='\033[0m' + + +here="$(dirname "$(readlink -f "$0")")" +cd "${here}/../.git/hooks" + +rm -f pre-push pre-commit || : +prepush_script="../../.git-hooks/pre-push.sh" +precommit_script="../../.git-hooks/pre-commit.sh" +[ -f "${prepush_script}" ] && ln -s "${prepush_script}" pre-push +[ -f "${precommit_script}" ] && ln -s "${precommit_script}" pre-commit + +echo -e "\n${GREEN}Done! Hooks applied, you can start committing and pushing!${NC}\n" diff --git a/.git-hooks/pre-push.sh b/.git-hooks/pre-push.sh new file mode 100755 index 0000000..e2025ac --- /dev/null +++ b/.git-hooks/pre-push.sh @@ -0,0 +1,18 @@ +#!/usr/bin/env bash +set -eu +set -o pipefail +set -o errtrace +shopt -s expand_aliases + +RED='\033[0;31m' +GREEN='\033[0;32m' +NC='\033[0m' + + +echo -e "Running pylint...\n" +if pylint lib; then + echo -e "\n${GREEN}Pylint found no errors!${NC}\n" +else + echo -e "\n${RED}Pylint failed with errors${NC}\n" + exit 1 +fi diff --git a/.pylintrc b/.pylintrc index f36e237..fd195bc 100644 --- a/.pylintrc +++ b/.pylintrc @@ -3,3 +3,9 @@ ignored-modules = zmq max-line-length = 120 disable = missing-docstring, too-few-public-methods, invalid-name + +[SIMILARITIES] + +ignore-comments=yes +ignore-docstrings=yes +ignore-imports=yes